GH-39843: [C++][Parquet] Parquet binary length overflow exception should contain the length of binary#39844
Merged
mapleFU merged 8 commits intoapache:mainfrom Feb 2, 2024
Conversation
|
|
# Conflicts: # cpp/src/parquet/column_writer.cc
wgtmac
reviewed
Jan 30, 2024
wgtmac
approved these changes
Jan 30, 2024
Member
Author
pitrou
reviewed
Jan 30, 2024
Member
Author
|
comment fixed @pitrou |
pitrou
approved these changes
Feb 1, 2024
Member
pitrou
left a comment
There was a problem hiding this comment.
Feel free to merge if CI is ok :-)
Member
Author
|
Don't know why CI continue fails. Rebase and run ci again |
Member
Author
|
I've checked the CI, seems these test failed for a few days. I'll merge it firstly |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 32bd01f. There were 2 benchmark results with an error:
There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Member
Author
|
Why do conbench has error =_= |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…on should contain the length of binary (apache#39844) ### Rationale for this change See apache#39843 It will be great to contain a string length in decoder. ### What changes are included in this PR? change the logging of encoding ### Are these changes tested? no ### Are there any user-facing changes? more specific error logging? * Closes: apache#39843 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #39843
It will be great to contain a string length in decoder.
What changes are included in this PR?
change the logging of encoding
Are these changes tested?
no
Are there any user-facing changes?
more specific error logging?