GH-39841: [GLib] Add support for GLib 2.56 again#39842
Merged
kou merged 1 commit intoapache:mainfrom Jan 30, 2024
Merged
Conversation
It's still used in CentOS 7 and AlmaLinux 8.
Member
Author
|
@github-actions crossbow submit -g linux |
|
|
|
Revision: a43d1ea Submitted crossbow builds: ursacomputing/crossbow @ actions-c00f143729
|
Member
Author
|
+1 |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit b778ace. There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change It's still used in CentOS 7 and AlmaLinux 8. ### What changes are included in this PR? Don't use `g_time_zone_get_identifier()` with GLib < 2.58. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#39841 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It's still used in CentOS 7 and AlmaLinux 8.
What changes are included in this PR?
Don't use
g_time_zone_get_identifier()with GLib < 2.58.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.