Skip to content

GH-39778: [C++] Fix tail-byte access cross buffer boundary in key hash avx2 #39800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pitrou merged 7 commits into from
Jan 26, 2024
Merged

GH-39778: [C++] Fix tail-byte access cross buffer boundary in key hash avx2 #39800

pitrou merged 7 commits into from
Jan 26, 2024

Conversation

@zanmato1984
Copy link
Contributor

@zanmato1984 zanmato1984 commented Jan 25, 2024 •
edited by github-actions bot
Loading

Rationale for this change

Issue #39778 seems caused by a careless (but hard to spot) bug in key hash avx2.

What changes are included in this PR?

Fix the careless bug.

Are these changes tested?

UT included.

Are there any user-facing changes?

No.

@zanmato1984
Copy link
Contributor Author

zanmato1984 commented Jan 25, 2024

cc @pitrou

pitrou
pitrou reviewed Jan 25, 2024
View reviewed changes
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jan 25, 2024
pitrou
pitrou approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pitrou
Copy link
Member

pitrou commented Jan 26, 2024

@github-actions crossbow submit -g cpp

@github-actions
Copy link

github-actions bot commented Jan 26, 2024

Revision: 5fea9bb

Submitted crossbow builds: ursacomputing/crossbow @ actions-cfeb62c110

Task Status
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind Azure
test-cuda-cpp GitHub Actions
test-debian-11-cpp-amd64 GitHub Actions
test-debian-11-cpp-i386 GitHub Actions
test-fedora-38-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions

@pitrou pitrou added this to the 15.0.1 milestone Jan 26, 2024
@pitrou pitrou merged commit 13b2234 into apache:main Jan 26, 2024
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Jan 26, 2024
@conbench-apache-arrow
Copy link

conbench-apache-arrow bot commented Jan 26, 2024

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 13b2234.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 202 possible false positives for unstable benchmarks that are known to sometimes produce them.

@conbench-apache-arrow
Copy link

conbench-apache-arrow bot commented Jan 26, 2024

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 13b2234.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 202 possible false positives for unstable benchmarks that are known to sometimes produce them.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@zanmato1984 @dgreiss
apacheGH-39778: [C++] Fix tail-byte access cross buffer boundary in k…
16d2adb 
…ey hash avx2 (apache#39800)

### Rationale for this change

Issue apache#39778 seems caused by a careless (but hard to spot) bug in key hash avx2.

### What changes are included in this PR?

Fix the careless bug.

### Are these changes tested?

UT included.

### Are there any user-facing changes?

No.

* Closes: apache#39778

Authored-by: Ruoxi Sun <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
raulcd pushed a commit that referenced this pull request Feb 20, 2024
@zanmato1984 @raulcd
GH-39778: [C++] Fix tail-byte access cross buffer boundary in key has…
faeab94 
…h avx2 (#39800)

### Rationale for this change

Issue #39778 seems caused by a careless (but hard to spot) bug in key hash avx2.

### What changes are included in this PR?

Fix the careless bug.

### Are these changes tested?

UT included.

### Are there any user-facing changes?

No.

* Closes: #39778

Authored-by: Ruoxi Sun <zanmato1984@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

15.0.1

Development

Successfully merging this pull request may close these issues.

[C++][Acero] ASAN reports heap buffer overflow in arrow::compute::Hashing32::ProcessStripes_avx2

2 participants

@zanmato1984 @pitrou