GH-39788: [Python] Validate max_chunksize in Table.to_batches#39796
Merged
raulcd merged 1 commit intoapache:mainfrom Feb 2, 2024
Merged
GH-39788: [Python] Validate max_chunksize in Table.to_batches#39796raulcd merged 1 commit intoapache:mainfrom
raulcd merged 1 commit intoapache:mainfrom
Conversation
|
|
Member
|
Thanks! |
raulcd
approved these changes
Feb 2, 2024
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 129a529. There were 7 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#39796) ### Rationale for this change Validating the keyword to be strictly positive, to avoid an infinite loop. * Closes: apache#39788 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Validating the keyword to be strictly positive, to avoid an infinite loop.
max_chunksize > 0inTable.to_batches()#39788