GH-39765: [C++][Dataset] Fix failures in dataset-scanner-benchmark #39794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiansen.chen <xiansen.chen@openpie.com>
mapleFU
reviewed
Jan 25, 2024
Signed-off-by: xiansen.chen <xiansen.chen@openpie.com>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 9c0a761. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…ark (apache#39794) ### Rationale for this change `ScanOnlyBench` use 2 kind of options to scan, but ignore the function `MakeScanNode` will return 4 extra columns. ### What changes are included in this PR? Change the expected result of bench `ScanOnlyBench` ### Are these changes tested? They covered by existing tests. * Closes: apache#39765 Authored-by: xiansen.chen <xiansen.chen@openpie.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ScanOnlyBenchuse 2 kind of options to scan, but ignore the functionMakeScanNodewill return 4 extra columns.What changes are included in this PR?
Change the expected result of bench
ScanOnlyBenchAre these changes tested?
They covered by existing tests.