Skip to content

GH-39774: [Go] Add public access to PreparedStatement handle#39775

Merged
zeroshade merged 1 commit intoapache:mainfrom
abandy:GH-39774
Jan 25, 2024
Merged

GH-39774: [Go] Add public access to PreparedStatement handle#39775
zeroshade merged 1 commit intoapache:mainfrom
abandy:GH-39774

Conversation

@abandy
Copy link
Copy Markdown
Contributor

@abandy abandy commented Jan 23, 2024

@github-actions
Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@abandy abandy changed the title Add public access to PreparedStatement handle GH-39774: [Go] Add public access to PreparedStatement handle Jan 23, 2024
@github-actions
Copy link
Copy Markdown

⚠️ GitHub issue #39774 has been automatically assigned in GitHub to PR creator.

@abandy abandy marked this pull request as ready for review January 24, 2024 00:08
@abandy abandy requested a review from zeroshade as a code owner January 24, 2024 00:08
@zeroshade
Copy link
Copy Markdown
Member

Would it make sense to add a small unit test to just ensure that it is populated and returned properly?

@abandy
Copy link
Copy Markdown
Contributor Author

abandy commented Jan 24, 2024

Would it make sense to add a small unit test to just ensure that it is populated and returned properly?

I updated the current client test to validate the value of the prepared statement handle property.

@zeroshade
Copy link
Copy Markdown
Member

Thanks @abandy!

@zeroshade zeroshade merged commit c97e6c4 into apache:main Jan 25, 2024
@zeroshade zeroshade removed the awaiting review Awaiting review label Jan 25, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jan 25, 2024
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c97e6c4.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…pache#39775)

* Closes: apache#39774

Authored-by: Alva Bandy <abandy@live.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@abandy abandy deleted the GH-39774 branch April 2, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Go] Need access to the PreparedStatement handle property

2 participants