GH-39667: [C++] Ensure dataset benchmarks present a bytes/s or items/s metric#39766
Merged
pitrou merged 1 commit intoapache:mainfrom Jan 24, 2024
Merged
GH-39667: [C++] Ensure dataset benchmarks present a bytes/s or items/s metric#39766pitrou merged 1 commit intoapache:mainfrom
pitrou merged 1 commit intoapache:mainfrom
Conversation
|
|
b4db8b4 to
0cbc6f1
Compare
westonpace
approved these changes
Jan 23, 2024
Member
westonpace
left a comment
There was a problem hiding this comment.
This looks good. Fragments / second seems like the right thing to report here.
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit df83e50. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…items/s metric (apache#39766) ### Rationale for this change Some of our microbenchmarks only present an iteration time in (nano,micro...)seconds. That is usually tedious to read and difficult to interpret. ### What changes are included in this PR? Ensure that benchmarks present a items/seconds and/or a bytes/seconds metric where that makes sense. ### Are these changes tested? Manually. ### Are there any user-facing changes? No. * Closes: apache#39667 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Some of our microbenchmarks only present an iteration time in (nano,micro...)seconds. That is usually tedious to read and difficult to interpret.
What changes are included in this PR?
Ensure that benchmarks present a items/seconds and/or a bytes/seconds metric where that makes sense.
Are these changes tested?
Manually.
Are there any user-facing changes?
No.