GH-39732: [Python][CI] Fix test failures with latest/nightly pandas#39760
Merged
jorisvandenbossche merged 2 commits intoapache:mainfrom Jan 25, 2024
Merged
Conversation
Member
|
Alternatively, we might also want to do a similar check of the |
Member
|
(this is somewhat similar as the discussion in #39394 (comment) for |
Member
Author
|
Did I understand correctly? -> 20be425 |
Member
Author
|
@github-actions crossbow submit test-conda-python-3.10-pandas-* |
|
Revision: 20be425 Submitted crossbow builds: ursacomputing/crossbow @ actions-dcc5b97ac0
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c67d026. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…ndas (apache#39760) This PR rearranges if-else blocks in the `table` function (`table.pxi`) so that pandas dataframe object comes before checking for `__arrow_c_stream__` and `__arrow_c_array__`. * Closes: apache#39732 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
raulcd
pushed a commit
that referenced
this pull request
Feb 20, 2024
…39760) This PR rearranges if-else blocks in the `table` function (`table.pxi`) so that pandas dataframe object comes before checking for `__arrow_c_stream__` and `__arrow_c_array__`. * Closes: #39732 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rearranges if-else blocks in the
tablefunction (table.pxi) so that pandas dataframe object comes before checking for__arrow_c_stream__and__arrow_c_array__.