GH-39683: [Release] Use temporary directory with TEST_BINARY=1#39684
Merged
raulcd merged 1 commit intoapache:mainfrom Jan 18, 2024
Merged
GH-39683: [Release] Use temporary directory with TEST_BINARY=1#39684raulcd merged 1 commit intoapache:mainfrom
raulcd merged 1 commit intoapache:mainfrom
Conversation
|
|
raulcd
approved these changes
Jan 18, 2024
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 1f5dece. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#39684) ### Rationale for this change We should use temporary directory to verify in clean environment. ### What changes are included in this PR? Use `ARROW_TMPDIR` for prefix of download directory. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#39683 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We should use temporary directory to verify in clean environment.
What changes are included in this PR?
Use
ARROW_TMPDIRfor prefix of download directory.Are these changes tested?
Yes.
Are there any user-facing changes?
No.