GH-39552: [Go] inclusion of option to use replacer when creating csv strings with go library#39576
Merged
zeroshade merged 2 commits intoapache:mainfrom Jan 17, 2024
Merged
GH-39552: [Go] inclusion of option to use replacer when creating csv strings with go library#39576zeroshade merged 2 commits intoapache:mainfrom
zeroshade merged 2 commits intoapache:mainfrom
Conversation
…g csv strings with go library
|
|
zeroshade
approved these changes
Jan 17, 2024
Member
zeroshade
left a comment
There was a problem hiding this comment.
this seems good to me. Thanks much!
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit c170af4. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…g csv strings with go library (apache#39576) Rationale for this change Make it possible to remove unwanted characters from strings What changes are included in this PR? Add new function to optionally setup a replacer in csv Writer Write method Are these changes tested? Yes Are there any user-facing changes? Adds an optional methods. * Closes: apache#39552 Lead-authored-by: Jânio <janioprates@gmail.com> Co-authored-by: janiodev <janio.otoni@blip.ai> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Make it possible to remove unwanted characters from strings
What changes are included in this PR?
Add new function to optionally setup a replacer in csv Writer Write method
Are these changes tested?
Yes
Are there any user-facing changes?
Adds an optional methods.