GH-39527: [C++][Parquet] Validate page sizes before truncating to int32 #39528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o int32 Be defensive instead of writing invalid data.
wgtmac
reviewed
Jan 9, 2024
Co-authored-by: Gang Wu <ustcwg@gmail.com>
mapleFU
reviewed
Jan 10, 2024
| DataPageV1 over_compressed_limit(buffer, /*num_values=*/100, Encoding::BIT_PACKED, | ||
| Encoding::BIT_PACKED, Encoding::BIT_PACKED, | ||
| /*uncompressed_size=*/100); | ||
| EXPECT_THROW(pager->WriteDataPage(over_compressed_limit), ParquetException); |
Member
There was a problem hiding this comment.
Should we uses EXPECT_THAT to gurantee "overflows to INT32_MAX"?
cpp/src/parquet/column_writer.cc
Outdated
|
|
||
| const uint8_t* output_data_buffer = compressed_data->data(); | ||
| if (compressed_data->size() > std::numeric_limits<int32_t>::max()) { | ||
| throw ParquetException("Compressed page size overflows to INT32_MAX."); |
Member
There was a problem hiding this comment.
should we note that the page type?
Member
There was a problem hiding this comment.
( Also can we print the page size? )
Member
|
@emkornfield Could we move forward? I'll approve if comment fixed |
Contributor
Author
|
Yes, will try to update this week. |
Contributor
Author
|
@mapleFU apologies for the delay, I think I've addressed your feedback. |
Member
wgtmac
approved these changes
Jan 24, 2024
pitrou
reviewed
Jan 24, 2024
|
|
||
| const uint8_t* output_data_buffer = compressed_data->data(); | ||
| if (compressed_data->size() > std::numeric_limits<int32_t>::max()) { | ||
| throw ParquetException( |
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
pitrou
approved these changes
Jan 25, 2024
Member
pitrou
left a comment
There was a problem hiding this comment.
LGTM except for one last suggestion
| ThrowsMessage<ParquetException>(HasSubstr("overflows INT32_MAX"))); | ||
| DictionaryPage dictionary_over_compressed_limit(buffer, /*num_values=*/100, | ||
| Encoding::PLAIN); | ||
| EXPECT_THROW(pager->WriteDictionaryPage(dictionary_over_compressed_limit), |
Member
There was a problem hiding this comment.
Sorry, didn't spot this, but perhaps also use EXPECT_THAT to check the exception message here?
mapleFU
reviewed
Jan 27, 2024
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 5d7f661. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 51 possible false positives for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…to int32 (apache#39528) Be defensive instead of writing invalid data. ### Rationale for this change Users can provide this API pages that are large to validly write and we silently truncate lengths before writing. ### What changes are included in this PR? Add validations and throw an exception if sizes are too large (this was previously checked only if page indexes are being build). ### Are these changes tested? Unit tested ### Are there any user-facing changes? This might start raising exceptions instead of writing out invalid parquet files. Closes apache#39527 **This PR contains a "Critical Fix".** * Closes: apache#39527 Lead-authored-by: emkornfield <emkornfield@gmail.com> Co-authored-by: Micah Kornfield <micahk@google.com> Co-authored-by: mwish <maplewish117@gmail.com> Co-authored-by: Antoine Pitrou <pitrou@free.fr> Co-authored-by: Gang Wu <ustcwg@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
raulcd
pushed a commit
that referenced
this pull request
Feb 20, 2024
…32 (#39528) Be defensive instead of writing invalid data. ### Rationale for this change Users can provide this API pages that are large to validly write and we silently truncate lengths before writing. ### What changes are included in this PR? Add validations and throw an exception if sizes are too large (this was previously checked only if page indexes are being build). ### Are these changes tested? Unit tested ### Are there any user-facing changes? This might start raising exceptions instead of writing out invalid parquet files. Closes #39527 **This PR contains a "Critical Fix".** * Closes: #39527 Lead-authored-by: emkornfield <emkornfield@gmail.com> Co-authored-by: Micah Kornfield <micahk@google.com> Co-authored-by: mwish <maplewish117@gmail.com> Co-authored-by: Antoine Pitrou <pitrou@free.fr> Co-authored-by: Gang Wu <ustcwg@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be defensive instead of writing invalid data.
Rationale for this change
Users can provide this API pages that are large to validly write and we silently truncate lengths before writing.
What changes are included in this PR?
Add validations and throw an exception if sizes are too large (this was previously checked only if page indexes are being build).
Are these changes tested?
Unit tested
Are there any user-facing changes?
This might start raising exceptions instead of writing out invalid parquet files.
Closes #39527
This PR contains a "Critical Fix".