GH-38988: [Go] Expose dictionary size from DictionaryBuilder#39521
Merged
zeroshade merged 2 commits intoapache:mainfrom Jan 9, 2024
Merged
GH-38988: [Go] Expose dictionary size from DictionaryBuilder#39521zeroshade merged 2 commits intoapache:mainfrom
zeroshade merged 2 commits intoapache:mainfrom
Conversation
|
|
zeroshade
reviewed
Jan 9, 2024
go/arrow/array/dictionary.go
Outdated
Comment on lines
1007
to
1011
Member
There was a problem hiding this comment.
We should probably add this to the DictionaryBuilder interface, yea?
0b05cd3 to
778f168
Compare
778f168 to
98b970f
Compare
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 92520c6. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#39521) ### Rationale for this change Details are in apache#38988 ### What changes are included in this PR? This adds a method to `DictionaryBuilder` that returns the current dictionary size. ### Are these changes tested? Updated an existing test to account for this new method. ### Are there any user-facing changes? Yes, a new method is added to `DictionaryBuilder`. * Closes: apache#38988 Authored-by: Ella Chao <ella.chao@datadoghq.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Details are in #38988
What changes are included in this PR?
This adds a method to
DictionaryBuilderthat returns the current dictionary size.Are these changes tested?
Updated an existing test to account for this new method.
Are there any user-facing changes?
Yes, a new method is added to
DictionaryBuilder.MemoTableof a dictionary builder #38988