GH-39427: [GLib] Update script and documentation#39428
Merged
kou merged 8 commits intoapache:mainfrom Jan 11, 2024
Merged
Conversation
|
|
efbbe44 to
742d931
Compare
Contributor
Author
|
Hello @kou I have updated the document regarding the issues I experienced while building GLib. I would appreciate it if you could review it when you have time. Thank you always. |
kou
reviewed
Jan 11, 2024
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Contributor
Author
|
@kou Hello. I have made all the revisions based on your comments. Thank you for the review. |
kou
reviewed
Jan 11, 2024
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 04afe3f. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change Modify scripts and update documentation for building GLib and running test code in a Mac environment. ### What changes are included in this PR? * Update Documentation (`c_glib/README.md`) * Update Script (`c_glib/test/run-test.sh`) ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#39427 Lead-authored-by: Hyunseok Seo <hsseo0501@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Modify scripts and update documentation for building GLib and running test code in a Mac environment.
What changes are included in this PR?
c_glib/README.md)c_glib/test/run-test.sh)Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.