GH-39233: [Compute] Add some duration kernels#39358
Conversation
pitrou
left a comment
There was a problem hiding this comment.
LGTM, but could you add the newly supported types in https://arrow.apache.org/docs/cpp/compute.html#arithmetic-functions ?
I changed them to "Numeric/Temporal" to be consistent with other functions. This may be misleading though since only duration is supported. |
|
Perhaps "Numeric/Duration" then? |
|
Sure. Updated. |
|
Thanks @js8544 , and sorry for the delay. |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 5709c0d. There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change Add kernels for durations. ### What changes are included in this PR? In this PR I added the ones that require only registration and unit tests. More complicated ones will be in another PR for readability. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#39233 Authored-by: Jin Shang <shangjin1997@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Rationale for this change
Add kernels for durations.
What changes are included in this PR?
In this PR I added the ones that require only registration and unit tests. More complicated ones will be in another PR for readability.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
durationadd missing kernels #39233