Skip to content

GH-39233: [Compute] Add some duration kernels#39358

Merged
pitrou merged 4 commits intoapache:mainfrom
js8544:jinshang/duration_kernels
Jan 11, 2024
Merged

GH-39233: [Compute] Add some duration kernels#39358
pitrou merged 4 commits intoapache:mainfrom
js8544:jinshang/duration_kernels

Conversation

@js8544
Copy link
Copy Markdown
Contributor

@js8544 js8544 commented Dec 23, 2023

Rationale for this change

Add kernels for durations.

What changes are included in this PR?

In this PR I added the ones that require only registration and unit tests. More complicated ones will be in another PR for readability.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link
Copy Markdown
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you add the newly supported types in https://arrow.apache.org/docs/cpp/compute.html#arithmetic-functions ?

@github-actions github-actions bot added awaiting committer review Awaiting committer review Component: Documentation and removed awaiting review Awaiting review labels Jan 9, 2024
@js8544
Copy link
Copy Markdown
Contributor Author

js8544 commented Jan 11, 2024

LGTM, but could you add the newly supported types in https://arrow.apache.org/docs/cpp/compute.html#arithmetic-functions ?

I changed them to "Numeric/Temporal" to be consistent with other functions. This may be misleading though since only duration is supported.

@pitrou
Copy link
Copy Markdown
Member

pitrou commented Jan 11, 2024

Perhaps "Numeric/Duration" then?

@js8544
Copy link
Copy Markdown
Contributor Author

js8544 commented Jan 11, 2024

Sure. Updated.

@pitrou pitrou merged commit 5709c0d into apache:main Jan 11, 2024
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Jan 11, 2024
@pitrou
Copy link
Copy Markdown
Member

pitrou commented Jan 11, 2024

Thanks @js8544 , and sorry for the delay.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jan 11, 2024
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 5709c0d.

There was 1 benchmark result with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change

Add kernels for durations.
### What changes are included in this PR?

In this PR I added the ones that require only registration and unit tests. More complicated ones will be in another PR for readability.
 

### Are these changes tested?
Yes.

### Are there any user-facing changes?
No.

* Closes: apache#39233

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++] duration add missing kernels

2 participants