GH-38833: [C++] Avoid hash_mean overflow#39349
Merged
pitrou merged 1 commit intoapache:mainfrom Jan 11, 2024
Merged
Conversation
Contributor
Author
|
Similar to #37243, but for |
7b2f703 to
b564ab6
Compare
Contributor
Author
Done |
pitrou
approved these changes
Jan 11, 2024
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit d181072. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change hash_mean overflows if the sum of a group is larger than uint64 max. ### What changes are included in this PR? Save the intermediate sum as double to avoid overflow ### Are these changes tested? yes ### Are there any user-facing changes? no * Closes: apache#38833 Authored-by: Jin Shang <shangjin1997@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
hash_mean overflows if the sum of a group is larger than uint64 max.
What changes are included in this PR?
Save the intermediate sum as double to avoid overflow
Are these changes tested?
yes
Are there any user-facing changes?
no