GH-39309: [Go][Parquet] handle nil bitWriter for DeltaBinaryPacked#39347
Merged
zeroshade merged 1 commit intoapache:mainfrom Jan 8, 2024
Merged
GH-39309: [Go][Parquet] handle nil bitWriter for DeltaBinaryPacked#39347zeroshade merged 1 commit intoapache:mainfrom
zeroshade merged 1 commit intoapache:mainfrom
Conversation
|
|
felipecrv
approved these changes
Dec 21, 2023
mapleFU
approved these changes
Dec 22, 2023
Member
|
Do we need to merge this @zeroshade ? |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0aadd5a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…ked (apache#39347) ### Rationale for this change If using the DeltaBinaryPacked encoding, we end up with a nil pointer dereference if we end up with an empty column. ### What changes are included in this PR? Add a nil check in `EstimatedDataEncodedSize` for the base `deltaBitPackEncoder`. This should only ever occur if we have an empty column with this encoding when closing a row group. ### Are these changes tested? Yes a unit test was added to verify the fix. * Closes: apache#39309 Authored-by: Matt Topol <zotthewizard@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
If using the DeltaBinaryPacked encoding, we end up with a nil pointer dereference if we end up with an empty column.
What changes are included in this PR?
Add a nil check in
EstimatedDataEncodedSizefor the basedeltaBitPackEncoder. This should only ever occur if we have an empty column with this encoding when closing a row group.Are these changes tested?
Yes a unit test was added to verify the fix.