GH-39322: [C++] Forward arguments to ExceptionToStatus all the way to Status::FromArgs #39323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in AzureLocation
This simplifies the creation of long error messages and leads to the use of a string builder to construct the error message.
…ernal.h But keep implementation in azurefs.cc to avoid having to expose currently azurefs.cc-private symbols in headers.
Contributor
Author
|
|
pitrou
approved these changes
Dec 20, 2023
Member
|
It seems you need to fix or circumvent the linting failure. |
Contributor
Author
Trying something! 🤞 |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 91b2243. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…way to Status::FromArgs (apache#39323) ### Rationale for this change This simplifies the creation of long error messages and leads to the use of a string builder to construct the error message. ### What changes are included in this PR? - std::forward in ExceptionToStatus - A few nitpicky changes - Simplification of the error message text - Moving the signature of `CheckIfHierarchicalNamespaceIsEnabled` to `azurefs_internal.h` to reduce the size of `azurefs.h` -- implementation remains in `azurefs.cc` ### Are these changes tested? Yes. By existing tests. * Closes: apache#39322 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This simplifies the creation of long error messages and leads to the use of a string builder to construct the error message.
What changes are included in this PR?
CheckIfHierarchicalNamespaceIsEnabledtoazurefs_internal.hto reduce the size ofazurefs.h-- implementation remains inazurefs.ccAre these changes tested?
Yes. By existing tests.