GH-38663: [C++] Add support for service-specific endpoint for S3 using AWS_ENDPOINT_URL_S3#39160
Merged
pitrou merged 2 commits intoapache:mainfrom Jan 8, 2024
messense:s3-fs-service-specific-endpoint-url
Merged
GH-38663: [C++] Add support for service-specific endpoint for S3 using AWS_ENDPOINT_URL_S3#39160pitrou merged 2 commits intoapache:mainfrom messense:s3-fs-service-specific-endpoint-url
AWS_ENDPOINT_URL_S3#39160pitrou merged 2 commits intoapache:mainfrom
messense:s3-fs-service-specific-endpoint-url
Conversation
|
|
Member
Author
|
Ping @pitrou can you take a look? Thanks! |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 1362122. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…3 using `AWS_ENDPOINT_URL_S3` (apache#39160) ### Rationale for this change See apache#38663 ### What changes are included in this PR? set variable `endpoint_override` according the environment variable, prefer service-specific endpoint url over global endpoint url. ### Are these changes tested? unittest ### Are there any user-facing changes? No * Closes: apache#38663 Lead-authored-by: messense <messense@icloud.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #38663
What changes are included in this PR?
set variable
endpoint_overrideaccording the environment variable, prefer service-specific endpoint url over global endpoint url.Are these changes tested?
unittest
Are there any user-facing changes?
No
AWS_ENDPOINT_URL_S3#38663