Skip to content

GH-38702 [C++]: Implement AzureFileSystem::DeleteRootDirContents #39151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felipecrv merged 1 commit into from
Dec 10, 2023
Merged

GH-38702 [C++]: Implement AzureFileSystem::DeleteRootDirContents #39151

felipecrv merged 1 commit into from
Dec 10, 2023

Conversation

@felipecrv
Copy link
Contributor

@felipecrv felipecrv commented Dec 8, 2023 •
edited by github-actions bot
Loading

Rationale for this change

This copies the behavior implemented by S3FileSystem.

What changes are included in this PR?

An implementation of DeleteRootDirContent that prevents deletion of all blob containers.

Are these changes tested?

N/A.

@felipecrv
Copy link
Contributor Author

felipecrv commented Dec 8, 2023

@kou @Tom-Newton

kou
kou approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

We will implement this when we add allow_container_deletion #38999, right?
(Or we may add one more option only for this something like allow_all_containers_deletion?)

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Dec 8, 2023
@Tom-Newton
Copy link
Contributor

Tom-Newton commented Dec 8, 2023

Personally I think it's reasonable to never implement this.

@felipecrv
Copy link
Contributor Author

felipecrv commented Dec 10, 2023

+1

We will implement this when we add allow_container_deletion #38999, right? (Or we may add one more option only for this something like allow_all_containers_deletion?)

s3fs doesn't infer that it's OK to delete all the buckets from these options and doesn't have an option allowing deleting everything. I think anyone that wants to delete all containers will either do it manually or via the official SDK if the want to do it programmatically.

@felipecrv felipecrv merged commit 47f4d18 into apache:main Dec 10, 2023
@felipecrv felipecrv removed the awaiting merge Awaiting merge label Dec 10, 2023
@felipecrv felipecrv deleted the root_dir_contents branch December 10, 2023 00:16
@conbench-apache-arrow
Copy link

conbench-apache-arrow bot commented Dec 10, 2023

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 47f4d18.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@felipecrv @dgreiss
apacheGH-38702 [C++]: Implement AzureFileSystem::DeleteRootDirContents (
e38132f 
apache#39151)

### Rationale for this change

This copies the behavior implemented by S3FileSystem.

### What changes are included in this PR?

An implementation of `DeleteRootDirContent` that prevents deletion of all blob containers.

### Are these changes tested?

N/A.
* Closes: apache#38702

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

+1 more reviewer

@Tom-Newton Tom-Newton Tom-Newton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++][FS][Azure] Implement DeleteRootDirContents()

3 participants

@felipecrv @Tom-Newton @kou