Skip to content

GH-38316: [C#] Implement interval types#39043

Merged
CurtHagenlocher merged 33 commits intoapache:mainfrom
CurtHagenlocher:Interval
Dec 10, 2023
Merged

GH-38316: [C#] Implement interval types#39043
CurtHagenlocher merged 33 commits intoapache:mainfrom
CurtHagenlocher:Interval

Conversation

@CurtHagenlocher
Copy link
Copy Markdown
Contributor

@CurtHagenlocher CurtHagenlocher commented Dec 2, 2023

What changes are included in this PR?

Changes required to support the three interval types in the C# implementation.

Are these changes tested?

Yes.

Are there any user-facing changes?

Adds new classes for interval support.

@CurtHagenlocher CurtHagenlocher marked this pull request as ready for review December 10, 2023 15:15
@CurtHagenlocher CurtHagenlocher merged commit 91f7330 into apache:main Dec 10, 2023
@CurtHagenlocher CurtHagenlocher removed the awaiting review Awaiting review label Dec 10, 2023
@CurtHagenlocher CurtHagenlocher deleted the Interval branch December 10, 2023 15:43
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 91f7330.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### What changes are included in this PR?

Changes required to support the three interval types in the C# implementation.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Adds new classes for interval support.
* Closes: apache#38316
* Closes: apache#29431

Lead-authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Co-authored-by: Platob <nfillot.pro@gmail.com>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C#] Implement interval types [C#] Add Support of Month, Day, Nano Type

2 participants