Skip to content

GH-39020: [CI][Release][JS] Use Node.js 18 instead of 16 #39021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 1 commit into from
Dec 1, 2023
Merged

GH-39020: [CI][Release][JS] Use Node.js 18 instead of 16 #39021

kou merged 1 commit into from
Dec 1, 2023

Conversation

@kou
Copy link
Member

@kou kou commented Dec 1, 2023 •
edited by github-actions bot
Loading

Rationale for this change

Node.js 16 reached EOL.

What changes are included in this PR?

Use Node.js 18. It's the oldest maintained LTS.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou kou requested review from assignUser and raulcd as code owners December 1, 2023 01:44
@github-actions
Copy link

github-actions bot commented Dec 1, 2023

⚠️ GitHub issue #39020 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Dec 1, 2023
@kou
Copy link
Member Author

kou commented Dec 1, 2023

@github-actions crossbow submit verify-rc-source-js-macos-*

@kou kou force-pushed the ci-macos-release-js branch from 7ae4d4f to 71ca928 Compare December 1, 2023 01:45
@github-actions
Copy link

github-actions bot commented Dec 1, 2023

Revision: 71ca928bdd93286894cb80e3cd880aa0f269b871

Submitted crossbow builds: ursacomputing/crossbow @ actions-aad18fbdce

Task Status
verify-rc-source-js-macos-amd64 Github Actions
verify-rc-source-js-macos-arm64 Github Actions

@kou kou force-pushed the ci-macos-release-js branch from 71ca928 to 8b975e2 Compare December 1, 2023 01:48
@kou
Copy link
Member Author

kou commented Dec 1, 2023

@github-actions crossbow submit verify-rc-source-js-linux-*

@kou kou force-pushed the ci-macos-release-js branch from 8b975e2 to 689f851 Compare December 1, 2023 01:50
@github-actions
Copy link

github-actions bot commented Dec 1, 2023

Revision: 8b975e28209f536b3077f6ec83d390e0438f5f7d

Submitted crossbow builds: ursacomputing/crossbow @ actions-38c184f0c3

Task Status
verify-rc-source-js-linux-almalinux-8-amd64 Github Actions
verify-rc-source-js-linux-conda-latest-amd64 Github Actions
verify-rc-source-js-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-js-linux-ubuntu-22.04-amd64 Github Actions

kou
kou commented Dec 1, 2023
View reviewed changes
dev/tasks/verify-rc/github.linux.amd64.yml Outdated
Copy link
Member Author

@kou kou Dec 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This .yml is used only for verify-rc-binaries-*-linux-amd64 and they don't use Node.js.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Dec 1, 2023
@kou kou force-pushed the ci-macos-release-js branch from 689f851 to 6cfe869 Compare December 1, 2023 05:33
@kou
Copy link
Member Author

kou commented Dec 1, 2023

@github-actions crossbow submit verify-rc-source-js-macos-amd64 verify-rc-source-js-linux-almalinux-8-amd64

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 1, 2023
@github-actions
Copy link

github-actions bot commented Dec 1, 2023

Revision: 6cfe869

Submitted crossbow builds: ursacomputing/crossbow @ actions-bf5982430a

Task Status
verify-rc-source-js-linux-almalinux-8-amd64 Github Actions
verify-rc-source-js-macos-amd64 Github Actions

kou
kou commented Dec 1, 2023
View reviewed changes
Copy link
Member Author

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit bcd096d into apache:main Dec 1, 2023
@kou kou deleted the ci-macos-release-js branch December 1, 2023 20:44
@kou kou removed the awaiting change review Awaiting change review label Dec 1, 2023
@github-actions github-actions bot added the awaiting changes Awaiting changes label Dec 1, 2023
@conbench-apache-arrow
Copy link

conbench-apache-arrow bot commented Dec 3, 2023

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit bcd096d.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@kou @dgreiss
apacheGH-39020: [CI][Release][JS] Use Node.js 18 instead of 16 (apach…
ff3e8c1 
…e#39021)

### Rationale for this change

Node.js 16 reached EOL.

### What changes are included in this PR?

Use Node.js 18. It's the oldest maintained LTS.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#39020

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

Assignees

No one assigned

Labels

awaiting changes Awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI][Release][JS] Node.js 16 is old for verification

1 participant

@kou