GH-38330: [C++][Azure] Use properties for input stream metadata #38524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of user defined metadata.
|
|
Member
Author
|
@Tom-Newton You may want to review this. |
Member
Author
|
I'll merge this in a few days if nobody objects this. |
felipecrv
reviewed
Nov 5, 2023
felipecrv
approved these changes
Nov 6, 2023
Member
Author
|
I'll merge this. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…apache#38524) ### Rationale for this change We use user defined metadata for input stream metadata for now. But we should use properties returned from Azure like other remove filesystem implementations such as S3 and GCS. ### What changes are included in this PR? Convert `Azure::Storage::Blobs::Models::BlobProperties` to `KeyValueMetadata`. The following values aren't supported yet: * `BlobProperties::ObjectReplicationSourceProperties` * `BlobProperties::Metadata` If they need, we will add support for them as a follow-up task. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#38330 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…apache#38524) ### Rationale for this change We use user defined metadata for input stream metadata for now. But we should use properties returned from Azure like other remove filesystem implementations such as S3 and GCS. ### What changes are included in this PR? Convert `Azure::Storage::Blobs::Models::BlobProperties` to `KeyValueMetadata`. The following values aren't supported yet: * `BlobProperties::ObjectReplicationSourceProperties` * `BlobProperties::Metadata` If they need, we will add support for them as a follow-up task. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#38330 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit f1820cb. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit f1820cb. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We use user defined metadata for input stream metadata for now. But we should use properties returned from Azure like other remove filesystem implementations such as S3 and GCS.
What changes are included in this PR?
Convert
Azure::Storage::Blobs::Models::BlobPropertiestoKeyValueMetadata. The following values aren't supported yet:BlobProperties::ObjectReplicationSourcePropertiesBlobProperties::MetadataIf they need, we will add support for them as a follow-up task.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.