GH-38341: [Python] Remove usage of pandas internals DatetimeTZBlock#38321
Merged
jorisvandenbossche merged 7 commits intoapache:mainfrom Jan 8, 2024
Merged
GH-38341: [Python] Remove usage of pandas internals DatetimeTZBlock#38321jorisvandenbossche merged 7 commits intoapache:mainfrom
jorisvandenbossche merged 7 commits intoapache:mainfrom
Conversation
|
|
Member
Author
|
So it seems that pandas doesn't preserve the unit in the DatetimeArray constructor: This seems fixed on the last pandas release 2.1, so will have to keep the older code using internals for the older pandas versions. |
Member
Author
|
@github-actions crossbow submit -g python |
|
Revision: a133014 Submitted crossbow builds: ursacomputing/crossbow @ actions-eda4ccd5da
|
|
|
Member
Author
|
@github-actions crossbow submit -g python |
|
Revision: dfcfa22 Submitted crossbow builds: ursacomputing/crossbow @ actions-6fbf28b83d
|
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 6b93c4a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…lock (apache#38321) ### Rationale for this change This usage probably stems from a long time ago that it was required to specify the Block type, but nowadays it's good enough to just specify the dtype, and thus cutting down on our usage of internal pandas objects. Part of apache#35081 * Closes: apache#38341 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This usage probably stems from a long time ago that it was required to specify the Block type, but nowadays it's good enough to just specify the dtype, and thus cutting down on our usage of internal pandas objects.
We only need to ensure the data passed is 2D, because it is always for a Block in a dataframe (not series), and otherwise it complains the placement doesn't match.Part of #35081