GH-38210: [C++][FlightRPC] Add missing app_metadata arguments#38231
Merged
lidavidm merged 2 commits intoapache:mainfrom Oct 12, 2023
Merged
GH-38210: [C++][FlightRPC] Add missing app_metadata arguments#38231lidavidm merged 2 commits intoapache:mainfrom
lidavidm merged 2 commits intoapache:mainfrom
Conversation
…IGHT_SQL=ON option
|
|
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit ed97d5c. There were 3 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 38 possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…pache#38231) ### Rationale for this change I have fixed the error occurring when using the "DARROW_FLIGHT_SQL=ON" option on a Mac with ARM Architecture CPU. ### What changes are included in this PR? It seems that implicit values are not recognized in this environment (Mac ARM), so I have added values explicitly. ### Are these changes tested? yes (build and run unit test) ### Are there any user-facing changes? No * Closes: apache#38210 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#38231) ### Rationale for this change I have fixed the error occurring when using the "DARROW_FLIGHT_SQL=ON" option on a Mac with ARM Architecture CPU. ### What changes are included in this PR? It seems that implicit values are not recognized in this environment (Mac ARM), so I have added values explicitly. ### Are these changes tested? yes (build and run unit test) ### Are there any user-facing changes? No * Closes: apache#38210 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
I have fixed the error occurring when using the "DARROW_FLIGHT_SQL=ON" option on a Mac with ARM Architecture CPU.
What changes are included in this PR?
It seems that implicit values are not recognized in this environment (Mac ARM), so I have added values explicitly.
Are these changes tested?
yes (build and run unit test)
Are there any user-facing changes?
No