Skip to content

GH-38061: [C#] Implement Duration support#38062

Merged
CurtHagenlocher merged 6 commits intoapache:mainfrom
CurtHagenlocher:Duration
Oct 16, 2023
Merged

GH-38061: [C#] Implement Duration support#38062
CurtHagenlocher merged 6 commits intoapache:mainfrom
CurtHagenlocher:Duration

Conversation

@CurtHagenlocher
Copy link
Copy Markdown
Contributor

@CurtHagenlocher CurtHagenlocher commented Oct 5, 2023

What changes are included in this PR?

Complete support for the Duration array type in the C# implementation.

Are these changes tested?

Yes.

Are there any user-facing changes?

The Duration array type is now supported in the C# library. This also does some slight refactoring of classes which could impact edge cases of user scenarios.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 5, 2023

⚠️ GitHub issue #38061 has been automatically assigned in GitHub to PR creator.

@jduo
Copy link
Copy Markdown
Member

jduo commented Oct 13, 2023

Looks good to me.

@CurtHagenlocher CurtHagenlocher merged commit 20e120b into apache:main Oct 16, 2023
@CurtHagenlocher CurtHagenlocher deleted the Duration branch October 16, 2023 16:28
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 20e120b.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
### What changes are included in this PR?

Complete support for the Duration array type in the C# implementation.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

The Duration array type is now supported in the C# library. This also
does some slight refactoring of classes which could impact edge cases of
user scenarios.
* Closes: apache#38061
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### What changes are included in this PR?

Complete support for the Duration array type in the C# implementation.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

The Duration array type is now supported in the C# library. This also
does some slight refactoring of classes which could impact edge cases of
user scenarios.
* Closes: apache#38061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C#] Implement duration support

2 participants