GH-37465: [Go] Add Value method to BooleanBuilder #37459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is not a MINOR change. Could you open a new issue for this? |
|
|
4 tasks
Contributor
|
cc @zeroshade |
zeroshade
approved these changes
Aug 31, 2023
4 tasks
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit d7b4d2d. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
### Rationale for this change Similar to the changes we've made in apache#35744 we need this for the BooleanBuilder too. ### What changes are included in this PR? Adding the method itself and adjusting a test to test both the Value method on the builder and the final array. ### Are these changes tested? Yes ### Are there any user-facing changes? Just an enhancement to get on-par with other builders. * Closes: apache#37465 Authored-by: Matthias Loibl <mail@matthiasloibl.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change Similar to the changes we've made in apache#35744 we need this for the BooleanBuilder too. ### What changes are included in this PR? Adding the method itself and adjusting a test to test both the Value method on the builder and the final array. ### Are these changes tested? Yes ### Are there any user-facing changes? Just an enhancement to get on-par with other builders. * Closes: apache#37465 Authored-by: Matthias Loibl <mail@matthiasloibl.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Similar to the changes we've made in #35744 we need this for the BooleanBuilder too.
What changes are included in this PR?
Adding the method itself and adjusting a test to test both the Value method on the builder and the final array.
Are these changes tested?
Yes
Are there any user-facing changes?
Just an enhancement to get on-par with other builders.