ARROW-4475: [Python] Fix recursive serialization of self-containing objects#3556
Closed
pcmoritz wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-4475: [Python] Fix recursive serialization of self-containing objects#3556pcmoritz wants to merge 2 commits intoapache:masterfrom
pcmoritz wants to merge 2 commits intoapache:masterfrom
Conversation
robertnishihara
approved these changes
Feb 5, 2019
Contributor
robertnishihara
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
xhochy
pushed a commit
that referenced
this pull request
Feb 8, 2019
…bjects This is a regression from #3423, the recursion depth was incremented for arrays and dicts but not for lists, tuples and sets. I also added a regression test for this. Author: Philipp Moritz <pcmoritz@gmail.com> Closes #3556 from pcmoritz/recursive-serialization and squashes the following commits: f83cff9 <Philipp Moritz> fix 903788e <Philipp Moritz> fix serialization of objects that contain themselves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a regression from #3423, the recursion depth was incremented for arrays and dicts but not for lists, tuples and sets.
I also added a regression test for this.