GH-34657: [Go] Add ValueString(i int) string to array by yevgenypats · Pull Request #34986 · apache/arrow

yevgenypats · 2023-04-08T14:35:16Z

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Closes: [Go][Array] Expose UntypedValue(i int) interface #34657
GitHub Issue: [Go][Array] Expose UntypedValue(i int) interface #34657

github-actions · 2023-04-08T14:35:36Z

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

github-actions · 2023-04-08T14:36:12Z

Closes: [Go][Array] Expose UntypedValue(i int) interface #34657

go/arrow/array/binary.go

go/arrow/array/binarybuilder_test.go

zeroshade · 2023-04-11T15:17:04Z

go/arrow/array/binarybuilder_test.go

 	ab.Release()
 	ar.Release()

+


just running go fmt would clear up the extraneous extra lines

Sure. BTW - maybe we should open an issue on adding a linter that runs fmt on all files as a pre-set ? this way it wont need review as I'll be able to just see in the CI. WDYT ? :)

I think that it would definitely be a good idea to add that to the existing linting. Right now the linter just runs staticcheck, but doesn't check the formatting.

go/arrow/array/string.go

go/arrow/array/struct.go

go/arrow/array/union.go

go/arrow/array/binarybuilder.go

go/arrow/array/builder.go

go/arrow/array/dictionary.go

zeroshade · 2023-04-12T15:36:22Z

@yevgenypats I've resolved the outdated issues you've fixed but there's still outstanding changes that need to be made such as #34986 (comment) and the other related comments.

go/arrow/array/struct_test.go

ursabot · 2023-04-16T12:22:59Z

Benchmark runs are scheduled for baseline = ff94702 and contender = f0c8229. f0c8229 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️7.14% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.49% ⬆️0.09%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] f0c8229f ec2-t3-xlarge-us-east-2
[Failed] f0c8229f test-mac-arm
[Finished] f0c8229f ursa-i9-9960x
[Finished] f0c8229f ursa-thinkcentre-m75q
[Finished] ff94702e ec2-t3-xlarge-us-east-2
[Failed] ff94702e test-mac-arm
[Finished] ff94702e ursa-i9-9960x
[Finished] ff94702e ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ursabot · 2023-04-16T12:24:05Z

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

…4986) ### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#34657 Authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>

### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * Closes: #34657 Authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>

yevgenypats requested a review from zeroshade as a code owner April 8, 2023 14:35

github-actions bot added the Component: Go label Apr 8, 2023

yevgenypats changed the title ~~feat: Feat/append from string~~ GH-34657: [Go] Add ValueString(i int) string to array Apr 8, 2023

github-actions bot added the awaiting review Awaiting review label Apr 8, 2023

yevgenypats mentioned this pull request Apr 8, 2023

[Go][Array] Expose UntypedValue(i int) interface #34657

Closed

zeroshade reviewed Apr 10, 2023

View reviewed changes

go/arrow/array/binary.go Outdated Show resolved Hide resolved

github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting review Awaiting review awaiting changes Awaiting changes labels Apr 10, 2023

yevgenypats requested a review from zeroshade April 10, 2023 23:35

github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 10, 2023

yevgenypats force-pushed the feat/append_from_string branch from 7d49c7e to 01739f6 Compare April 11, 2023 00:31

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 11, 2023

zeroshade requested changes Apr 11, 2023

View reviewed changes

github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Apr 11, 2023

yevgenypats requested a review from zeroshade April 12, 2023 12:12

github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 12, 2023

zeroshade reviewed Apr 12, 2023

View reviewed changes

go/arrow/array/binarybuilder.go Outdated Show resolved Hide resolved

zeroshade reviewed Apr 12, 2023

View reviewed changes

go/arrow/array/builder.go Outdated Show resolved Hide resolved

zeroshade reviewed Apr 12, 2023

View reviewed changes

go/arrow/array/dictionary.go Outdated Show resolved Hide resolved

yevgenypats added 8 commits April 12, 2023 23:51

fix tests

aef7931

test

89b381b

fix rebase

3923051

fix binary

d3aeab5

some fixes

504f991

fix review

47b6b77

review

abbda16

review fix

9612cb7

yevgenypats force-pushed the feat/append_from_string branch from d93ab3d to 9612cb7 Compare April 12, 2023 20:52

yevgenypats requested a review from zeroshade April 12, 2023 20:53

zeroshade reviewed Apr 12, 2023

View reviewed changes

go/arrow/array/struct_test.go Outdated Show resolved Hide resolved

github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 12, 2023

fix review

dc20b31

yevgenypats requested a review from zeroshade April 13, 2023 11:20

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 13, 2023

zeroshade approved these changes Apr 13, 2023

View reviewed changes

zeroshade merged commit f0c8229 into apache:main Apr 13, 2023

github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Apr 13, 2023

candiduslynx mentioned this pull request May 3, 2023

[Go] Some types don't follow the ValueStr <-> AppendValueFromStr convention #35421

Closed

candiduslynx deleted the feat/append_from_string branch June 2, 2023 11:57

singh1203 mentioned this pull request Jan 27, 2025

[Go][Builder] Add AppendFromText method apache/arrow-go#65

Closed

Conversation

yevgenypats commented Apr 8, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Apr 8, 2023

Uh oh!

github-actions bot commented Apr 8, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zeroshade Apr 11, 2023

Choose a reason for hiding this comment

Uh oh!

yevgenypats Apr 11, 2023

Choose a reason for hiding this comment

Uh oh!

zeroshade Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zeroshade commented Apr 12, 2023

Uh oh!

Uh oh!

ursabot commented Apr 16, 2023

Uh oh!

ursabot commented Apr 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yevgenypats commented Apr 8, 2023 •

edited by github-actions bot

Loading