GH-34309: [C++] Disable LTO for aws_lc and s2n-tls#34349
Merged
kou merged 18 commits intoapache:mainfrom Mar 1, 2023
Merged
Conversation
Contributor
Author
|
@github-actions crossbow submit -g nightly-packaging |
Contributor
Author
|
@github-actions crossbow submit ubuntu-jammy-amd64 ubuntu-kinetic-amd64 ubuntu-focal-amd64 ubuntu-jammy-arm64 ubuntu-kinetic-arm64 ubuntu-focal-arm64 |
|
Revision: 4cfeb3e36a2b319994bac55dd17c9aa3860fe11a Submitted crossbow builds: ursacomputing/crossbow @ actions-fdf56bf738
|
4cfeb3e to
a8ee2ed
Compare
|
Revision: 4cfeb3e36a2b319994bac55dd17c9aa3860fe11a Submitted crossbow builds: ursacomputing/crossbow @ actions-b72302d779
|
Contributor
Author
|
@github-actions crossbow submit -g nightly-packaging |
|
Revision: a8ee2ed Submitted crossbow builds: ursacomputing/crossbow @ actions-422babc51e
|
Contributor
Author
|
@github-actions crossbow submit -g nightly-packaging |
|
Revision: aff0c65 Submitted crossbow builds: ursacomputing/crossbow @ actions-cd6f09f951
|
Contributor
Author
|
@github-actions crossbow submit -g nightly-packaging |
|
Revision: 82d28e2 Submitted crossbow builds: ursacomputing/crossbow @ actions-fe9d6ff109
|
Contributor
Author
|
@github-actions crossbow submit -g nightly-packaging |
|
Revision: facb82f Submitted crossbow builds: ursacomputing/crossbow @ actions-c2e3f8a3f6
|
Contributor
Author
|
Hi @kou, the undefined reference issue is resolved. But ubuntu-jammy-amd64 and ubuntu-kinetic-amd64 are still failing due to out of disk space errors. Their corresponding arm builds are successful though. |
Member
|
Thanks! |
Member
|
@github-actions crossbow submit ubuntu-jammy-amd64 |
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
@github-actions crossbow submit ubuntu-jammy-amd64 |
|
Revision: 51c1496 Submitted crossbow builds: ursacomputing/crossbow @ actions-c44e4f717f
|
Member
|
@github-actions crossbow submit ubuntu-jammy-amd64 |
Member
|
@github-actions crossbow submit ubuntu-jammy-amd64 |
|
Revision: 26fef2d Submitted crossbow builds: ursacomputing/crossbow @ actions-a92c39bfb4
|
|
Revision: dc52be5 Submitted crossbow builds: ursacomputing/crossbow @ actions-458af9f016
|
Member
|
@github-actions crossbow submit ubuntu-jammy-amd64 |
|
Revision: 40d70ef Submitted crossbow builds: ursacomputing/crossbow @ actions-69374b2c42
|
Member
|
@github-actions crossbow submit ubuntu-jammy-amd64 |
|
Revision: f59a873 Submitted crossbow builds: ursacomputing/crossbow @ actions-a81e884fae
|
Contributor
Author
|
@github-actions crossbow submit -g nightly-packaging |
|
Revision: f59a873 Submitted crossbow builds: ursacomputing/crossbow @ actions-a7d80c6712
|
Member
|
@github-actions crossbow submit ubuntu-jammy-amd64 almalinux-9-amd64 |
|
Revision: 0c05e04 Submitted crossbow builds: ursacomputing/crossbow @ actions-62c149bc4a
|
kou
approved these changes
Mar 1, 2023
Member
kou
left a comment
There was a problem hiding this comment.
+1
Disk space reduction is ad-hoc. Similar problem may be happen later...
|
Benchmark runs are scheduled for baseline = 6776229 and contender = f9a1d19. f9a1d19 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When built with LTO, s2n-tls can't properly intern aws_lc symbols, which may cause undefined references.