disable LTO for s2n

js8544 · js8544 · commit facb82f35667 · 2023-02-26T15:16:26.000Z
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -4871,11 +4871,18 @@ macro(build_awssdk)
                         BUILD_BYPRODUCTS ${AWS_LC_STATIC_LIBRARY})
     add_dependencies(AWS::crypto aws_lc_ep)
 
+    set(S2N_TLS_C_FLAGS ${EP_C_FLAGS})
+    string(APPEND S2N_TLS_C_FLAGS " -Wno-error=overlength-strings -Wno-error=pedantic")
+    # Link time optimization is causing trouble like #34349
+    string(REPLACE "-flto=auto" "" S2N_TLS_C_FLAGS "${S2N_TLS_C_FLAGS}")
+    string(REPLACE "-ffat-lto-objects" "" S2N_TLS_C_FLAGS "${S2N_TLS_C_FLAGS}")
+
     set(S2N_TLS_CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS})
     list(APPEND
          S2N_TLS_CMAKE_ARGS
          -DS2N_INTERN_LIBCRYPTO=ON # internalize libcrypto to avoid name conflict with openssl
-         -DCMAKE_PREFIX_PATH=${AWS_LC_PREFIX}) # path to find crypto provided by aws-lc
+         -DCMAKE_PREFIX_PATH=${AWS_LC_PREFIX} # path to find crypto provided by aws-lc
+         -DCMAKE_C_FLAGS=${S2N_TLS_C_FLAGS}) 
 
     externalproject_add(s2n_tls_ep
                         ${EP_COMMON_OPTIONS}
@@ -4885,9 +4892,6 @@ macro(build_awssdk)
                         BUILD_BYPRODUCTS ${S2N_TLS_STATIC_LIBRARY}
                         DEPENDS aws_lc_ep)
     add_dependencies(AWS::s2n-tls s2n_tls_ep)
-    set_property(TARGET AWS::s2n-tls
-                 APPEND
-                 PROPERTY INTERFACE_LINK_LIBRARIES OpenSSL::Crypto OpenSSL::SSL)
   endif()
 
   externalproject_add(aws_c_cal_ep
