GH-34214: [C++] Pass OPENSSL_ROOT_HINT to CMAKE_PREFIX_PATH for bundled AWS#34215
Merged
kou merged 6 commits intoapache:mainfrom Feb 17, 2023
Merged
GH-34214: [C++] Pass OPENSSL_ROOT_HINT to CMAKE_PREFIX_PATH for bundled AWS#34215kou merged 6 commits intoapache:mainfrom
kou merged 6 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@github-actions crossbow submit -g wheel |
|
|
|
Revision: 90ce53d Submitted crossbow builds: ursacomputing/crossbow @ actions-37af5b4d68
|
Contributor
Author
|
@github-actions crossbow submit -g wheel |
|
Revision: b873b00 Submitted crossbow builds: ursacomputing/crossbow @ actions-2b7258d865
|
Contributor
Author
|
@github-actions crossbow submit -g wheel -g cpp -g r java-jars |
1 similar comment
Contributor
Author
|
@github-actions crossbow submit -g wheel -g cpp -g r java-jars |
|
Revision: b873b00 Submitted crossbow builds: ursacomputing/crossbow @ actions-9d23ca25c3
|
Contributor
Author
|
@github-actions crossbow submit -g wheel -g cpp -g r java-jars |
|
Revision: 5c2965d Submitted crossbow builds: ursacomputing/crossbow @ actions-2419e9b7a1
|
Contributor
Author
|
@github-actions crossbow submit -g wheel -g cpp -g r java-jars |
|
Revision: 7455c5b Submitted crossbow builds: ursacomputing/crossbow @ actions-0de38c891c
|
Contributor
Author
|
@github-actions crossbow submit -g wheel -g cpp -g r java-jars |
|
Revision: 61b4ba1 Submitted crossbow builds: ursacomputing/crossbow @ actions-bd348f6b16
|
Contributor
Author
|
@kou manylinux builds are good now :) |
kou
approved these changes
Feb 17, 2023
Member
kou
left a comment
There was a problem hiding this comment.
+1
Thanks! Could you fix order before we merge this?
| "-DCMAKE_PREFIX_PATH=${AWSSDK_PREFIX}") | ||
|
|
||
| -DCMAKE_INSTALL_PREFIX=${AWSSDK_PREFIX} | ||
| -DCMAKE_PREFIX_PATH=${AWSSDK_PREFIX}\\$<SEMICOLON>${OPENSSL_ROOT_HINT}) |
|
Benchmark runs are scheduled for baseline = 79563cf and contender = 2721fa6. 2721fa6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix build failures such as #34159 (comment), we need to help it find OpenSSL.