ARROW-3647: [R] Fix R bit64 crash and formatting#2867
Closed
javierluraschi wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-3647: [R] Fix R bit64 crash and formatting#2867javierluraschi wants to merge 1 commit intoapache:masterfrom
javierluraschi wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2867 +/- ##
=======================================
Coverage 87.56% 87.56%
=======================================
Files 411 411
Lines 63818 63818
=======================================
Hits 55881 55881
Misses 7867 7867
Partials 70 70Continue to review full report at Codecov.
|
Contributor
|
LGTM |
Member
|
+1 |
Contributor
|
It's not clear to me that this fix is correct — I don't think you can generally expect to unload R packages containing C code and still have things work. |
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Nov 1, 2018
apache#2867 broke installation, this fixes it with [ARROW-3657](https://issues.apache.org/jira/projects/ARROW/issues/ARROW-3657). CC: @romainfrancois Author: Javier Luraschi <javierluraschi@hotmail.com> Closes apache#2876 from javierluraschi/bugfix/arrow-bit64-deps and squashes the following commits: acc7ab8 <Javier Luraschi> ARROW-3591: fix dependency not required bit64
Member
|
Am I correct that this fix allows the loading of bit64 to be deferred? |
Contributor
|
As far as I can see, the fix does the opposite - it forces loading of bit64 when arrow is loaded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for https://issues.apache.org/jira/browse/ARROW-3647 by adding a dependency to
bit64inarrowwhich will avoid lettingbit64be unloaded whilearrowis loaded.Additionally, fix for sparklyr/sparklyr#1736, which was preventing tibbles using
integer64to be formatted properly ifbit64was not loaded explicitly.CC: @romainfrancois