ARROW-2499: [C++] Factor out Python iteration routines #1940
Conversation
23cc975 to
20640f7
Compare
d9fbd37 to
7740c23
Compare
|
There are npm failures on Travis-CI (most probably unrelated, I'd say :-)). |
There was a problem hiding this comment.
Can you make a JIRA for this and reference as // TODO(ARROW-XXX): ?
0387487 to
f2c7e8c
Compare
xhochy
left a comment
There was a problem hiding this comment.
A bit of confused by one XXX otherwise this is ready to go
There was a problem hiding this comment.
Is this is a problem that should be fixed here?
There was a problem hiding this comment.
I don't know. Perhaps the naming is simply wrong. I should take a look where it's used.
There was a problem hiding this comment.
Turns out it's unused currently.
f2c7e8c to
f402337
Compare
xhochy
left a comment
There was a problem hiding this comment.
+1, LGTM, merge on green build
|
Looks like PR #1945 needs merging to solve the build issues (or at least some of them). |
f402337 to
c93bdca
Compare
c93bdca to
ac31c6c
Compare
|
AppVeyor build: https://ci.appveyor.com/project/pitrou/arrow/build/1.0.366 |
Speeds up list to Arrow conversions by up to 15%. Also fixes a bug where creating a list array would not check that all input items are sequences.
Based on PR #1935.