ARROW-2503: [Python] Prevent trailing space character for string statistics #1945
Conversation
|
I guess this depends on the PR in |
|
Sorry, I was a bit to eager to open this PR. I want to solve it without depending on the PR in I'll reiterate. |
8c54fb7 to
57cdb6f
Compare
|
I updated the scope of this PR, see the description above. |
|
@jneuff, could you rebase this PR so that we get a fresh CI build? |
This accounts for the fixed behavior of FormatStatValue as described in PARQUET-1283.
57cdb6f to
f702f18
Compare
|
I opened a competing PR #1973 to get CI as soon as possible. Let's see which one ends first. |
|
@pitrou you should also have the right to push to contributor branches on github, no need to open new PRs if it's only a rebase. |
|
In the past I've messed up things while trying to push to contributor branches :-) |
|
Also the goal is to get an AppVeyor build on my account. |
|
AppVeyor build succeeded at https://ci.appveyor.com/project/pitrou/arrow/build/1.0.359 |
The trailing space is added in
parquet-cpp.pyarrowcalls the functionFormatStatValuewhich adds the trailing space (https://github.com/apache/parquet-cpp/blob/master/src/parquet/types.cc#L52).https://issues.apache.org/jira/browse/PARQUET-1283 is about fixing this behavior. Once the corresponding PR is merged into
parquet-cppandpyarrowis synced, thetest_parquet.py:test_parquet_column_statistics_apiwill break forstr. This PR fixes that breakage.