ARROW-18436: [C++] Ensure correct (un)escaping of special characters in URI paths#14974
Conversation
|
@westonpace @vibhatha This may affect Substrait, though it should be for the better. |
|
@jorisvandenbossche @AlenkaF This sanitizes the |
bf977c1 to
4f620c5
Compare
looks good to me, @westonpace do you see any issues? |
westonpace
left a comment
There was a problem hiding this comment.
I agree it's for the better, thanks. A few small thoughts.
cpp/src/arrow/util/uri.cc
Outdated
There was a problem hiding this comment.
Minor nit: I think we've been preferring to pass string_view by value in Substrait per https://quuxplusone.github.io/blog/2021/11/09/pass-string-view-by-value/ and @bkietz 's advice
cpp/src/arrow/util/uri.cc
Outdated
There was a problem hiding this comment.
Minor nit: Maybe a comment explaining this math? Probably not needed if this is a normal Windows thing.
There was a problem hiding this comment.
This is simply as per the uriWindowsFilenameToUriStringA doc:
https://uriparser.github.io/doc/api/latest/Uri_8h.html#a422dc4a2b979ad380a4dfe007e3de845
4f620c5 to
91caabb
Compare
|
Benchmark runs are scheduled for baseline = 793e5f6 and contender = ceec795. ceec795 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
…in URI paths (apache#14974) Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
No description provided.