ARROW-1885: [Java] Restore MapVector class names prior to ARROW-1710 #1389
Conversation
|
@siddharthteotia I manually checked differences of this change to those done in #1341 to ensure readers/writers and others are back to the previous state, but please double check and let me know if you feel comfortable with this. |
| return reader; | ||
| } | ||
|
|
||
| transient private MapTransferPair ephPair; |
There was a problem hiding this comment.
how so, you mean the name?
There was a problem hiding this comment.
keep in mind the diff is showing the result of renaming NonNullableMapVector to MapVector and none of the code was actually changed, just the class name
There was a problem hiding this comment.
Oh sorry I should be clear - the variable name ephPair seems wrong - I don't know if it has always been ephPair or somehow changed during refactoring. Either way, seems worth fixing.
There was a problem hiding this comment.
Oh ok, I'm not sure of the reason for the name, this is how it was previously to ARROW-1710. I'd prefer to keep the changes here to that scope so we can be sure they are restored correctly.
|
LGTM except for what seems to be a typo . |
|
+1 |
|
Thanks all for the quick reviews! |
Changes to MapVector were not part of the intended goal for ARROW-1710 and should be restored to `NullableMapVector` -> `MapVector` -> `AbstractMapVector` as existed prior to apache#1341. Author: Bryan Cutler <cutlerb@gmail.com> Closes apache#1389 from BryanCutler/java-restore-MapVector-class-ARROW-1885 and squashes the following commits: 9ff503a [Bryan Cutler] restore MapVector class names 3d818f0 [Bryan Cutler] renamed NonNullableMapVector to MapVector ced1705 [Bryan Cutler] renamed MapVector to NullableMapVector
Changes to MapVector were not part of the intended goal for ARROW-1710 and should be restored to
NullableMapVector->MapVector->AbstractMapVectoras existed prior to #1341.