ARROW-1850: [C++] Use void* / const void* for buffers in file APIs #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Id4ef313c989ee7cf23813e99051dbeea44a3d949
Member
Author
|
I will fix the glib bindings |
xhochy
approved these changes
Nov 27, 2017
Change-Id: I4a4a930f642e6a43ea166ae6cc90729d02efe213
wesm
added a commit
that referenced
this pull request
Dec 1, 2017
This makes for a more convenient / less rigid API without as need for as many usages of `reinterpret_cast<const uint8_t*>`. This does not impact downstream projects (e.g. parquet-cpp is unaffected) unless they provide implementations of these virtual interfaces. Author: Wes McKinney <wes.mckinney@twosigma.com> Closes #1363 from wesm/ARROW-1850 and squashes the following commits: af5a348 [Wes McKinney] Update glib, arrow-gpu for API changes 5d5cf2d [Wes McKinney] Use void* / const void* for buffers in file APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes for a more convenient / less rigid API without as need for as many usages of
reinterpret_cast<const uint8_t*>. This does not impact downstream projects (e.g. parquet-cpp is unaffected) unless they provide implementations of these virtual interfaces.