Skip to content

Conversation

@assignUser
Copy link
Member

@assignUser assignUser commented May 13, 2022

No description provided.

@github-actions
Copy link

@assignUser
Copy link
Member Author

@github-actions submit crossbow r-nightly-packages

@assignUser assignUser changed the title ARROW-16403: [R][CI] Create Crossbow task for R nightly builds ARROW-16403: [WIP][R][CI] Create Crossbow task for R nightly builds May 13, 2022
@assignUser
Copy link
Member Author

@github-actions crossbow submit r-nightly-packages

@github-actions
Copy link

Failed to render template `r/github.nightly.yml` with UndefinedError: 'today' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2319267442

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-nightly-packages

@github-actions
Copy link

Failed to render template `r/github.nightly.yml` with UndefinedError: 'today' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2319711041

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-nightly-packages

@github-actions
Copy link

Revision: 968f2fa150b2b786e883ab877e7dc39917123121

Submitted crossbow builds: ursacomputing/crossbow @ actions-2087

Task Status
r-nightly-packages Github Actions

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-nightly-packages

@github-actions
Copy link

Revision: 47c3ce81ec2470361afd4b40e09deec04babf2b4

Submitted crossbow builds: ursacomputing/crossbow @ actions-2088

Task Status
r-nightly-packages Github Actions

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-nightly-packages

@github-actions
Copy link

Revision: cbe4a5fdd3d036f5614153fafe9c36b3f0a4aa00

Submitted crossbow builds: ursacomputing/crossbow @ actions-2089

Task Status
r-nightly-packages Github Actions

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-nightly-packages

@github-actions
Copy link

Revision: 02839e641f45723bdc238727c4ee7e4c58d3b8f6

Submitted crossbow builds: ursacomputing/crossbow @ actions-2090

Task Status
r-nightly-packages Github Actions

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-nightly-packages

@github-actions
Copy link

Revision: 88957ba3314471ba5fcd840ca7139a0b3358ccdb

Submitted crossbow builds: ursacomputing/crossbow @ actions-2096

Task Status
r-nightly-packages Github Actions

@assignUser
Copy link
Member Author

@github-actions crossbow submit -r https://github.com/assignUser/arrow -t f8d1a42 r-nightly-packages

@github-actions
Copy link

No such option: -r
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2338802136

@assignUser
Copy link
Member Author

@github-actions crossbow -r https://github.com/assignUser/arrow -t f8d1a42 submit r-nightly-packages

@github-actions
Copy link

No such option: -r
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2338819157

@assignUser assignUser marked this pull request as ready for review May 17, 2022 15:50
@assignUser
Copy link
Member Author

@github-actions crossbow submit r-nightly-packages

@github-actions
Copy link

Revision: a247a5a48079d167e789a5002a67b91f246bf605

Submitted crossbow builds: ursacomputing/crossbow @ actions-2103

Task Status
r-nightly-packages Github Actions

@assignUser
Copy link
Member Author

assignUser commented May 17, 2022

@kszucs @nealrichardson I think this is ready for review, here is a complete run based on the HEAD of #13173. The stand in for https://nightlies.apache.org I used is https://nightly.wujciak.de/r

With #13173 working we could introduce these jobs to the nightly packaging task and run them for a few days with uploading to https://nightlies.apache.org before we change docs and defaults.

Final steps to activate this:
- add the task to the nightly packaging builds
- update secrets

@assignUser assignUser changed the title ARROW-16403: [WIP][R][CI] Create Crossbow task for R nightly builds ARROW-16403:[R][CI] Create Crossbow task for R nightly builds May 17, 2022
@assignUser assignUser changed the title ARROW-16403:[R][CI] Create Crossbow task for R nightly builds ARROW-16403:[WIP][R][CI] Create Crossbow task for R nightly builds May 25, 2022
@assignUser
Copy link
Member Author

@github-actions crossbow submit r-nightly-packages

@github-actions
Copy link

Failed to render template `r/github.nightly.yml` with UndefinedError: 'today' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2385602055

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-nightly-packages

@github-actions
Copy link

Failed to render template `r/github.nightly.yml` with UndefinedError: 'today' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2385624603

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-nightly-packages

@github-actions
Copy link

Revision: 6c061fc

Submitted crossbow builds: ursacomputing/crossbow @ actions-1a613b312e

Task Status
r-nightly-packages Github Actions

@assignUser assignUser requested a review from kszucs May 25, 2022 16:42
@assignUser
Copy link
Member Author

@kszucs The upload of the releases on crossbow side should work I used the template for it. The R code to setup the repo/folder structure works, I tested it locally with real artifacts and correct names etc..

I added a workflow dispatch for this so that we can test it and for use in the R release process, we can only test this once it is merged.

I am not sure if we need to set up the nightlies.a.o/r/arrow folders manually with curl before running this wf.

@assignUser assignUser changed the title ARROW-16403:[WIP][R][CI] Create Crossbow task for R nightly builds ARROW-16403:[R][CI] Create Crossbow task for R nightly builds May 25, 2022
@assignUser
Copy link
Member Author

@kszucs tested everything except the upload to nightlies.a.o successfully here with custom prefix and on push as a stand-in for schedule (aka no inputs)

Imho this can be merged now.

Possible Follow-Ups:

  • Restore multi-version repo index (got lost due the way the rsync action works)
  • M1 binaries
  • Improved caching
  • Make use of pattern validation

Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't get to review before this merged, but here is some feedback. One other point: we should add something to the LICENSE or NOTICE file attributing the source of this to the arrow-r-nightly repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree: none of the other crossbow jobs that run nightly have nightly in the name (except some python ones where "nightly" refers to the version of pandas or numpy being tested). The workflow name should describe what work is happening, not what schedule it is running on.

@ursabot
Copy link

ursabot commented May 26, 2022

Benchmark runs are scheduled for baseline = 9a7cc52 and contender = 156dc72. 156dc72 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.58% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.36% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.39% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 156dc72c ec2-t3-xlarge-us-east-2
[Finished] 156dc72c test-mac-arm
[Finished] 156dc72c ursa-i9-9960x
[Finished] 156dc72c ursa-thinkcentre-m75q
[Finished] 9a7cc522 ec2-t3-xlarge-us-east-2
[Finished] 9a7cc522 test-mac-arm
[Finished] 9a7cc522 ursa-i9-9960x
[Finished] 9a7cc522 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@assignUser assignUser deleted the ARROW-16403-nightly-crossbow branch June 21, 2022 07:53
nealrichardson pushed a commit that referenced this pull request Jul 8, 2022
merge after #13149 

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants