-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-16403:[R][CI] Create Crossbow task for R nightly builds #13149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-16403:[R][CI] Create Crossbow task for R nightly builds #13149
Conversation
|
@github-actions submit crossbow r-nightly-packages |
|
@github-actions crossbow submit r-nightly-packages |
|
|
@github-actions crossbow submit r-nightly-packages |
|
|
@github-actions crossbow submit r-nightly-packages |
|
Revision: 968f2fa150b2b786e883ab877e7dc39917123121 Submitted crossbow builds: ursacomputing/crossbow @ actions-2087
|
|
@github-actions crossbow submit r-nightly-packages |
|
Revision: 47c3ce81ec2470361afd4b40e09deec04babf2b4 Submitted crossbow builds: ursacomputing/crossbow @ actions-2088
|
|
@github-actions crossbow submit r-nightly-packages |
|
Revision: cbe4a5fdd3d036f5614153fafe9c36b3f0a4aa00 Submitted crossbow builds: ursacomputing/crossbow @ actions-2089
|
|
@github-actions crossbow submit r-nightly-packages |
|
Revision: 02839e641f45723bdc238727c4ee7e4c58d3b8f6 Submitted crossbow builds: ursacomputing/crossbow @ actions-2090
|
|
@github-actions crossbow submit r-nightly-packages |
|
Revision: 88957ba3314471ba5fcd840ca7139a0b3358ccdb Submitted crossbow builds: ursacomputing/crossbow @ actions-2096
|
|
@github-actions crossbow submit -r https://github.com/assignUser/arrow -t f8d1a42 r-nightly-packages |
|
|
@github-actions crossbow -r https://github.com/assignUser/arrow -t f8d1a42 submit r-nightly-packages |
|
|
@github-actions crossbow submit r-nightly-packages |
|
Revision: a247a5a48079d167e789a5002a67b91f246bf605 Submitted crossbow builds: ursacomputing/crossbow @ actions-2103
|
|
@kszucs @nealrichardson I think this is ready for review, here is a complete run based on the HEAD of #13173. The stand in for https://nightlies.apache.org I used is https://nightly.wujciak.de/r With #13173 working we could introduce these jobs to the nightly packaging task and run them for a few days with uploading to https://nightlies.apache.org before we change docs and defaults. Final steps to activate this:
|
|
@github-actions crossbow submit r-nightly-packages |
|
This reverts commit a448f47.
|
@github-actions crossbow submit r-nightly-packages |
|
This reverts commit 1e9bf59.
|
@github-actions crossbow submit r-nightly-packages |
|
Revision: 6c061fc Submitted crossbow builds: ursacomputing/crossbow @ actions-1a613b312e
|
|
@kszucs The upload of the releases on crossbow side should work I used the template for it. The R code to setup the repo/folder structure works, I tested it locally with real artifacts and correct names etc.. I added a workflow dispatch for this so that we can test it and for use in the R release process, we can only test this once it is merged. I am not sure if we need to set up the nightlies.a.o/r/arrow folders manually with curl before running this wf. |
|
@kszucs tested everything except the upload to nightlies.a.o successfully here with custom prefix and on push as a stand-in for schedule (aka no inputs) Imho this can be merged now. Possible Follow-Ups:
|
nealrichardson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't get to review before this merged, but here is some feedback. One other point: we should add something to the LICENSE or NOTICE file attributing the source of this to the arrow-r-nightly repo.
dev/tasks/r/github.nightly.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree: none of the other crossbow jobs that run nightly have nightly in the name (except some python ones where "nightly" refers to the version of pandas or numpy being tested). The workflow name should describe what work is happening, not what schedule it is running on.
|
Benchmark runs are scheduled for baseline = 9a7cc52 and contender = 156dc72. 156dc72 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
merge after #13149 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
No description provided.