Skip to content

ARROW-15712 [R] Add a type method for Expression objects #12447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dragosmg wants to merge 2 commits into from
Closed

ARROW-15712 [R] Add a type method for Expression objects #12447

dragosmg wants to merge 2 commits into from

Conversation

@dragosmg
Copy link
Contributor

@dragosmg dragosmg commented Feb 17, 2022

This would allow for more consistent syntax when extracting the type of an expression.
A block like this:

if (inherits(x, "Expression")) { 
class <- x$type()$ToString() 
} else { 
class <- type(x)$ToString() 
}

would be simplified to

class <- type(x)$ToString()

@github-actions
Copy link

github-actions bot commented Feb 17, 2022

https://issues.apache.org/jira/browse/ARROW-15712

@dragosmg dragosmg mentioned this pull request Feb 17, 2022
Closed
@dragosmg dragosmg marked this pull request as ready for review February 17, 2022 10:06
dragosmg added a commit to dragosmg/arrow that referenced this pull request Feb 17, 2022
@dragosmg
simplify class extraction once apache#12447 is merged
792f4ae
@dragosmg dragosmg changed the title ARROW-15712 [R] Add a type method for Expression ARROW-15712 [R] Add a type method for Expression objects Feb 17, 2022
thisisnic
thisisnic approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@thisisnic thisisnic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@thisisnic thisisnic closed this in cd20efb Feb 18, 2022
@ursabot
Copy link

ursabot commented Feb 18, 2022 •
edited
Loading

Benchmark runs are scheduled for baseline = 4a439c2 and contender = cd20efb. cd20efb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.34% ⬆️0.85%] test-mac-arm
[Failed ⬇️0.36% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

jonkeane pushed a commit to dragosmg/arrow that referenced this pull request Feb 19, 2022
@dragosmg @jonkeane
simplify class extraction once apache#12447 is merged
554345b
@dragosmg dragosmg deleted the type_method_for_expression branch February 24, 2022 09:24
@asfimport asfimport mentioned this pull request Feb 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thisisnic thisisnic thisisnic approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dragosmg @ursabot @thisisnic