ARROW-15514: [C++][Gandiva] Add flag to enable Gandiva Object Code#12308
Closed
anthonylouisbsb wants to merge 5 commits intoapache:masterfrom
Closed
ARROW-15514: [C++][Gandiva] Add flag to enable Gandiva Object Code#12308anthonylouisbsb wants to merge 5 commits intoapache:masterfrom
anthonylouisbsb wants to merge 5 commits intoapache:masterfrom
Conversation
|
|
77434d6 to
32cbe51
Compare
projjal
approved these changes
Feb 1, 2022
32cbe51 to
911cbfa
Compare
|
Benchmark runs are scheduled for baseline = 56e270f and contender = 4e1c79e. 4e1c79e is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
pravindra
pushed a commit
that referenced
this pull request
Feb 11, 2022
Add a flag that was missing in that PR to [add a flag related to the Object Code cache](#12308) Caching the entire projector/filter instead of object cache has a higher memory overhead so need to lower the size when not using object code caching. Closes #12394 from anthonylouisbsb/fixbug/fix-gandiva-cache-size Authored-by: Anthony Louis <anthony@simbioseventures.com> Signed-off-by: Pindikura Ravindra <ravindra@dremio.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That PR adds a flag in C++ code to enable or disable the object code cache when Gandiva stores an expression.
The reason for that is some expressions are crashing when the object code is enabled, we are identifying that.