ARROW-14519: [C++] Properly error if joining on unsupported type#11625
ARROW-14519: [C++] Properly error if joining on unsupported type#11625lidavidm wants to merge 2 commits intoapache:masterfrom
Conversation
|
|
|
CC @michalursa. Note that the KeyColumnMetadata computed here is unused, but computing it here serves as a useful up-front check as otherwise we run into a DCHECK later during plan execution instead, so I opted to keep it. |
|
Moved the validation to HashJoinSchema::ValidateSchemas as suggested on JIRA. |
|
|
michalursa
left a comment
There was a problem hiding this comment.
I realized that KeyColumnMetadata was not needed. The reason it exists is that it was meant for future changes to hash join and I forgot to remove it in the original hash join change.
|
Benchmark runs are scheduled for baseline = ae808e0 and contender = 412da89. 412da89 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Instead of DCHECK, return a NotImplemented. Closes #11625 from lidavidm/arrow-14519 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Instead of DCHECK, return a NotImplemented.