ARROW-14035: [C++][Python][R] Implement count distinct kernel #11257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
lidavidm
reviewed
Sep 28, 2021
Member
lidavidm
left a comment
There was a problem hiding this comment.
I realize this is very much a draft, but I left some notes.
edponce
reviewed
Sep 28, 2021
edponce
reviewed
Sep 28, 2021
Member
|
@aucahuasi may I push a commit to this PR to implement the R binding? (ARROW-14036) |
Contributor
Author
|
@ianmcook sure! |
Contributor
Author
7765ce6 to
8d61f6a
Compare
Contributor
Author
8d61f6a to
5570299
Compare
edponce
reviewed
Sep 29, 2021
edponce
suggested changes
Sep 29, 2021
pitrou
requested changes
Sep 29, 2021
Member
pitrou
left a comment
There was a problem hiding this comment.
Thanks for doing this. I'm adding some comments to Eduardo's.
lidavidm
reviewed
Sep 29, 2021
5570299 to
47571c7
Compare
ianmcook
reviewed
Oct 1, 2021
ianmcook
reviewed
Oct 1, 2021
47571c7 to
e6c7d1d
Compare
Contributor
Author
edponce
suggested changes
Oct 2, 2021
efe7974 to
5711dfd
Compare
ianmcook
reviewed
Oct 3, 2021
cc10c5f to
a1b6dbb
Compare
pitrou
requested changes
Oct 4, 2021
Member
pitrou
left a comment
There was a problem hiding this comment.
Thanks for the update @aucahuasi . It looks like there's a couple issues remaining, see below.
e0c42bb to
5c47cda
Compare
finish basic implementation & add tests and docs add count_distinct_doc add R binding for count_distinct kernel support more types & add more tests minor change reduce code use type matchers to reduce even more code minor change Update docs/source/cpp/compute.rst Co-authored-by: Ian Cook <ianmcook@gmail.com> minor changes add tests for scalar types and fix an issue for scalars
5c47cda to
5de1a5c
Compare
pitrou
approved these changes
Oct 5, 2021
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
https://issues.apache.org/jira/browse/ARROW-14035 Closes apache#11257 from aucahuasi/ARROW-14035-implement-count_distinct-kernel Lead-authored-by: Percy Camilo Triveño Aucahuasi <percy.camilo.ta@gmail.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/ARROW-14035