ARROW-14050: [C++] Make TDigest/Quantile kernels return nulls instead #11199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for doing this @lidavidm! I'll test this with the R bindings later today. |
pitrou
approved these changes
Sep 21, 2021
| for (const auto& ty : {float64(), int64(), uint64()}) { | ||
| QuantileOptions options(std::vector<double>{0.0, 0.5, 1.0}); | ||
| EXPECT_THAT(Quantile(*MakeScalar(ty, 1), options), | ||
| ResultWith(ArrayFromJSON(float64(), "[1.0, 1.0, 1.0]"))); |
Member
There was a problem hiding this comment.
Did you mean to also test with a null scalar here?
Member
Author
There was a problem hiding this comment.
Yes, added (also added to TDigest's tests)
Member
|
Works great from the R bindings. Thanks! |
ianmcook
approved these changes
Sep 21, 2021
lidavidm
added a commit
that referenced
this pull request
Sep 24, 2021
This wraps the tdigest aggregation to make it easier for bindings to use. This PR is on top of ARROW-14050 (#11199). Closes #11204 from lidavidm/arrow-14052 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
As requested, this makes it so that TDigest/Quantile return nulls instead of empty arrays, making them easier to consume from bindings, and making them compose better with kernels like list_flatten and list_element. Closes apache#11199 from lidavidm/arrow-14050 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
This wraps the tdigest aggregation to make it easier for bindings to use. This PR is on top of ARROW-14050 (apache#11199). Closes apache#11204 from lidavidm/arrow-14052 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, this makes it so that TDigest/Quantile return nulls instead of empty arrays, making them easier to consume from bindings, and making them compose better with kernels like list_flatten and list_element.