Skip to content

Conversation

@BryanCutler
Copy link
Member

This makes the child fields of ListVector have consistent names of ListVector.DATA_VECTOR_NAME. Previously, an empty ListVector would have a child name of ZeroVector.name which is "[DEFAULT]".

@BryanCutler
Copy link
Member Author

Continuation of #959 to use instanceof and add a test. cc @jacques-n @wesm @StevenMPhillips

@StevenMPhillips
Copy link
Contributor

+1 LGTM

@asfgit asfgit closed this in cfcee74 Sep 21, 2017
@BryanCutler
Copy link
Member Author

Thanks @StevenMPhillips!

siddharthteotia pushed a commit to siddharthteotia/arrow that referenced this pull request Oct 6, 2017
This makes the child fields of ListVector have consistent names of `ListVector.DATA_VECTOR_NAME`. Previously, an empty ListVector would have a child name of `ZeroVector.name` which is "[DEFAULT]".

Author: Bryan Cutler <cutlerb@gmail.com>
Author: Steven Phillips <steven@dremio.com>

Closes apache#1119 from BryanCutler/java-ListVector-child-name-ARROW-1347 and squashes the following commits:

c240378 [Bryan Cutler] changed to use instanceof and added test
2923a45 [Steven Phillips] ARROW-1347: [JAVA] return consistent child field name for List vectors
@BryanCutler BryanCutler deleted the java-ListVector-child-name-ARROW-1347 branch November 7, 2017 23:50
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
This makes the child fields of ListVector have consistent names of `ListVector.DATA_VECTOR_NAME`. Previously, an empty ListVector would have a child name of `ZeroVector.name` which is "[DEFAULT]".

Author: Bryan Cutler <cutlerb@gmail.com>
Author: Steven Phillips <steven@dremio.com>

Closes apache#1119 from BryanCutler/java-ListVector-child-name-ARROW-1347 and squashes the following commits:

c240378 [Bryan Cutler] changed to use instanceof and added test
2923a45 [Steven Phillips] ARROW-1347: [JAVA] return consistent child field name for List vectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants