ARROW-13502: [R] Bindings for min/max aggregation #11175
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnic
previously requested changes
Sep 20, 2021
Member
thisisnic
left a comment
There was a problem hiding this comment.
A few minor suggestions, otherwise LGTM!
ianmcook
commented
Sep 20, 2021
ianmcook
commented
Sep 20, 2021
Co-authored-by: Nic <thisisnic@gmail.com>
Co-authored-by: Nic <thisisnic@gmail.com>
Co-authored-by: Nic <thisisnic@gmail.com>
d3ebebb to
3da00f5
Compare
thisisnic
approved these changes
Sep 20, 2021
Member
thisisnic
left a comment
There was a problem hiding this comment.
Couple of super minor things but they're pretty trivial
Co-authored-by: Nic <thisisnic@gmail.com>
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
Adds bindings for `min()` and `max()` in `dplyr::summarise()` Closes apache#11175 from ianmcook/ARROW-13502 Authored-by: Ian Cook <ianmcook@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bindings for
min()andmax()indplyr::summarise()