Skip to content

Conversation

@michalursa
Copy link
Contributor

@michalursa michalursa commented Sep 14, 2021

Hash join node implementation.

Complete implementation of in-memory hash join, except for:

  • residual predicates (non-equality join conditions accompanying equality conditions in case of outer joins)
  • support for dictionary data types.

This is a simple implementation that is not performance optimized. More advanced implementation (adding e.g. Bloom-like filters) will follow.

Supports all 8 flavors of the join: left semi, left anti-semi, right semi, right anti-semi, inner, left outer, right outer and full outer join.
Note that left semi join, for instance, is not the same as right semi join with inputs swapped. They have the same effect but the algorithm is different in both cases.
Left semi join will filter out rows with no matches coming from left (first) child exec node.
Right semi join will keep track of whether there was a match for each row for right (second) child exec node inserted into a hash table and output hash table rows with matches at the end.

Supports the same keys as hash group by node, except for lack of support for dictionaries and strings with 64-bit offset.

Supports choosing for each corresponding pair of key fields whether null should match null or not.

@github-actions
Copy link

@bkietz bkietz self-requested a review September 14, 2021 17:47
@michalursa michalursa force-pushed the ARROW-13642-ref-imp branch 3 times, most recently from 48e50b5 to c0be8ea Compare September 16, 2021 00:43
Copy link
Member

@bkietz bkietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments so far

@jonkeane jonkeane marked this pull request as ready for review September 30, 2021 13:48
@jonkeane jonkeane closed this in 5a5d929 Sep 30, 2021
jonkeane added a commit that referenced this pull request Sep 30, 2021
This is based on #11150.

Among the issues observed:

* Dictionary columns aren't allowed even in the left data, though you can first `Project` to remove them
* Duplicate column names aren't allowed at all, even though there is a provision for deduping with a prefix

Closes #11155 from nealrichardson/join-dplyr

Lead-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
… inner, outer join types

Hash join node implementation.

Complete implementation of in-memory hash join, except for:
- residual predicates (non-equality join conditions accompanying equality conditions in case of outer joins)
- support for dictionary data types.

This is a simple implementation that is not performance optimized. More advanced implementation (adding e.g. Bloom-like filters) will follow.

Supports all 8 flavors of the join: left semi, left anti-semi, right semi, right anti-semi, inner, left outer, right outer and full outer join.
Note that left semi join, for instance, is not the same as right semi join with inputs swapped. They have the same effect but the algorithm is different in both cases.
Left semi join will filter out rows with no matches coming from left (first) child exec node.
Right semi join will keep track of whether there was a match for each row for right (second) child exec node inserted into a hash table and output hash table rows with matches at the end.

Supports the same keys as hash group by node, except for lack of support for dictionaries and strings with 64-bit offset.

Supports choosing for each corresponding pair of key fields whether null should match null or not.

Closes apache#11150 from michalursa/ARROW-13642-ref-imp

Lead-authored-by: michalursa <michal@ursacomputing.com>
Co-authored-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
This is based on apache#11150.

Among the issues observed:

* Dictionary columns aren't allowed even in the left data, though you can first `Project` to remove them
* Duplicate column names aren't allowed at all, even though there is a provision for deduping with a prefix

Closes apache#11155 from nealrichardson/join-dplyr

Lead-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants