ARROW-13974: [C++] Resolve follow-up reviews for TopK/BottomK #11132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
lidavidm
reviewed
Sep 10, 2021
edponce
reviewed
Sep 10, 2021
edponce
reviewed
Sep 10, 2021
Contributor
|
LGTM. Thanks for working on this @aocsa! |
Contributor
Author
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
There are some follow-up reviews for topK/bottomK kernel (ARROW-1565) that were requested after PR was closed. This issue is to resolve them. Closes apache#11132 from aocsa/ARROW-13974 Authored-by: Alexander <aocsa.cs@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some follow-up reviews for topK/bottomK kernel (ARROW-1565) that were requested after PR was closed. This issue is to resolve them.