ARROW-1553: [JAVA] Implement setInitialCapacity for MapWriter #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. Maybe we want a test for MapWriter? |
Contributor
|
LGTM. Definitely helps our use case. Agree with @icexelloss that we should add a test as well for this situation. |
Contributor
Author
|
Added unit test |
754b375 to
a2540cd
Compare
…is capacity during lazy creation of child vectors
a2540cd to
5a759be
Compare
Contributor
Author
|
Can this be merged? |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Implement setInitialCapacity for MapWriter and pass on this capacity during lazy creation of child vectors cc @jacques-n , @StevenMPhillips Author: siddharth <siddharth@dremio.com> Closes apache#1113 from siddharthteotia/ARROW-1553 and squashes the following commits: 5a759be [siddharth] ARROW-1553: Implement setInitialCapacity for MapWriter and pass on this capacity during lazy creation of child vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement setInitialCapacity for MapWriter and pass on this capacity during lazy creation of child vectors
cc @jacques-n , @StevenMPhillips