Skip to content

Conversation

@lidavidm
Copy link
Member

No description provided.

@github-actions
Copy link

@lidavidm lidavidm marked this pull request as draft September 10, 2021 13:27
@lidavidm lidavidm marked this pull request as ready for review September 10, 2021 14:31
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this came up in a different PR or discussion somewhere, but this makes it so that decimal-integer addition works 'properly' now if the decimal precision wasn't big enough to hold the integer (now it will promote both to a larger decimal type).

Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small nit on docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Decimal not part of Numeric? I don't see any reason to call it out special here given that we don't do so for add/multiply/divide/subtract.

Although, to be fair, we don't currently support decimal for the rest of the math operations (trig, pow/ln, etc.) and that's more than just a casting issue so it may be sometime before we do offer support. So we might want to call out that fact.

Either way, I think we should keep this page consistent. Either decimal is part of "Numeric" everywhere or nowhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, "Numeric" is defined up top as often including decimal. The blurb about promotion here should suffice, I think; I also added a blurb about decimal promotion to the arithmetic section.

@lidavidm lidavidm closed this in 293f856 Sep 13, 2021
ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
Closes apache#11129 from lidavidm/arrow-13966

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants