ARROW-13869: [R] Implement options for non-bound MatchSubstringOptions kernels #11102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@github-actions crossbow submit test-r-build-minimal |
Member
Author
|
In two minds as to whether there's much point to this PR or not, given it's implementing options classes for kernels which are to have bindings implemented for at some point anyway, and likely before the next release (see linked issues in comments) |
Member
Author
|
@github-actions crossbow submit test-r-minimal-build |
|
Revision: 6af202310612d684795ac454c063be5b119d640b Submitted crossbow builds: ursacomputing/crossbow @ actions-833
|
Member
|
@github-actions autotune everything |
nealrichardson
approved these changes
Sep 9, 2021
Member
nealrichardson
left a comment
There was a problem hiding this comment.
Looks like there are still some lint messages but hopefully autotune will fix them. Otherwise LGTM
e0dcf62 to
2e01c2b
Compare
Member
Author
|
@github-actions autotune |
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
…s kernels Closes apache#11102 from thisisnic/ARROW-13869_misc_compute Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.